Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: make headers self-contained #1030

Merged
merged 1 commit into from
Jan 4, 2024
Merged

feat: make headers self-contained #1030

merged 1 commit into from
Jan 4, 2024

Conversation

sergiud
Copy link
Collaborator

@sergiud sergiud commented Jan 4, 2024

No description provided.

@sergiud sergiud added this to the 0.7 milestone Jan 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 4, 2024

Codecov Report

Attention: 42 lines in your changes are missing coverage. Please review.

Comparison is base (dfce35c) 59.14% compared to head (63f445a) 58.95%.

Files Patch % Lines
src/flags.cc 27.50% 1 Missing and 28 partials ⚠️
src/includes_unittest/glog_includes_raw_logging.cc 0.00% 6 Missing ⚠️
src/includes_unittest/glog_includes_logging.cc 0.00% 5 Missing ⚠️
src/includes_unittest/glog_includes_stl_logging.cc 0.00% 1 Missing ⚠️
src/includes_unittest/glog_includes_vlog_is_on.cc 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1030      +/-   ##
==========================================
- Coverage   59.14%   58.95%   -0.20%     
==========================================
  Files          18       23       +5     
  Lines        2541     2553      +12     
  Branches      907      912       +5     
==========================================
+ Hits         1503     1505       +2     
- Misses        694      706      +12     
+ Partials      344      342       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sergiud sergiud merged commit 8775a45 into master Jan 4, 2024
268 checks passed
@sergiud sergiud deleted the self-contained-header branch January 4, 2024 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants